diff --git a/devops-service/db/validators/base.rb b/devops-service/db/validators/base.rb index 0cb68f9..677e9f2 100644 --- a/devops-service/db/validators/base.rb +++ b/devops-service/db/validators/base.rb @@ -9,7 +9,7 @@ module Validators def validate! raise InvalidRecord.new(message) unless valid? rescue StandardError => e - puts [e.message, e.backtrace].join("\n") + DevopsLogger.logger.error [e.message, e.backtrace].join("\n") raise InvalidRecord.new("An error raised during validation with #{self.class}: #{e.class}: #{e.message}") end diff --git a/devops-service/spec/models/deploy_env/deploy_env_ec2_spec.rb b/devops-service/spec/models/deploy_env/deploy_env_ec2_spec.rb index 8bbf1d0..1886a1c 100644 --- a/devops-service/spec/models/deploy_env/deploy_env_ec2_spec.rb +++ b/devops-service/spec/models/deploy_env/deploy_env_ec2_spec.rb @@ -5,7 +5,7 @@ require_relative 'shared_cloud_deploy_env_specs' RSpec.describe Devops::Model::DeployEnvEc2, type: :model do let(:env) { build(:deploy_env_ec2) } - describe 'it inherits from cloud deploy_env', stubbed_env_validators: true do + describe 'it inherits from cloud deploy_env', stubbed_env_validators: true, stubbed_logger: true do it_behaves_like 'deploy env' it_behaves_like 'cloud deploy env' end diff --git a/devops-service/spec/models/deploy_env/deploy_env_openstack_spec.rb b/devops-service/spec/models/deploy_env/deploy_env_openstack_spec.rb index e1a54de..96fdfd7 100644 --- a/devops-service/spec/models/deploy_env/deploy_env_openstack_spec.rb +++ b/devops-service/spec/models/deploy_env/deploy_env_openstack_spec.rb @@ -5,7 +5,7 @@ require_relative 'shared_cloud_deploy_env_specs' RSpec.describe Devops::Model::DeployEnvOpenstack, type: :model do let(:env) { build(:deploy_env_openstack) } - describe 'it inherits from cloud deploy_env', stubbed_env_validators: true do + describe 'it inherits from cloud deploy_env', stubbed_env_validators: true, stubbed_logger: true do it_behaves_like 'deploy env' it_behaves_like 'cloud deploy env' end diff --git a/devops-service/spec/models/image_spec.rb b/devops-service/spec/models/image_spec.rb index a90912d..39e630d 100644 --- a/devops-service/spec/models/image_spec.rb +++ b/devops-service/spec/models/image_spec.rb @@ -15,7 +15,7 @@ RSpec.describe Devops::Model::Image, type: :model do expect(image).to be_valid end - describe 'validation' do + describe 'validation', stubbed_logger: true do include_examples 'field type validation', :id, :not_nil, :non_empty_string, :field_validator include_examples 'field type validation', :remote_user, :not_nil, :non_empty_string, :field_validator include_examples 'field type validation', :name, :not_nil, :non_empty_string, :field_validator diff --git a/devops-service/spec/models/key_spec.rb b/devops-service/spec/models/key_spec.rb index 8a2108c..bed5d79 100644 --- a/devops-service/spec/models/key_spec.rb +++ b/devops-service/spec/models/key_spec.rb @@ -7,7 +7,7 @@ RSpec.describe Devops::Model::Key, type: :model do expect(key).to be_valid end - describe 'validations' do + describe 'validations', stubbed_logger: true do it 'key file should exist in file system' do expect(build(:key, path: './not_exist')).not_to be_valid end diff --git a/devops-service/spec/models/project_spec.rb b/devops-service/spec/models/project_spec.rb index dd892b1..6457ebb 100644 --- a/devops-service/spec/models/project_spec.rb +++ b/devops-service/spec/models/project_spec.rb @@ -3,7 +3,7 @@ require 'db/mongo/models/project' RSpec.describe Devops::Model::Project, type: :model do let(:project) { build(:project) } - describe 'validation rules:', stubbed_env_validators: true do + describe 'validation rules:', stubbed_env_validators: true, stubbed_logger: true do include_examples 'field type validation', :id, :not_nil, :non_empty_string include_examples 'field type validation', :deploy_envs, :not_nil, :non_empty_array include_examples 'field type validation', :description, :maybe_nil, :maybe_empty_string diff --git a/devops-service/spec/models/provider_account/openstack_provider_account_spec.rb b/devops-service/spec/models/provider_account/openstack_provider_account_spec.rb index e601778..537d36d 100644 --- a/devops-service/spec/models/provider_account/openstack_provider_account_spec.rb +++ b/devops-service/spec/models/provider_account/openstack_provider_account_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' RSpec.describe Devops::Model::OpenstackProviderAccount, type: :model do let(:provider_account) { build(:openstack_provider_account) } - it "should not validate access_key_id" do + it "should not validate access_key_id", stubbed_logger: true do fields = described_class.field_validators.values.flatten.flatten.map{|t| t[:field]} expect(fields).not_to include(:access_key_id, :secret_access_key) end diff --git a/devops-service/spec/models/server_spec.rb b/devops-service/spec/models/server_spec.rb index d49f328..c744618 100644 --- a/devops-service/spec/models/server_spec.rb +++ b/devops-service/spec/models/server_spec.rb @@ -11,7 +11,7 @@ RSpec.describe Devops::Model::Server, type: :model do expect(server).to be_valid end - describe 'validation rules:' do + describe 'validation rules:', stubbed_logger: true do include_examples 'field type validation', :id, :not_nil, :non_empty_string include_examples 'field type validation', :provider, :not_nil, :non_empty_string include_examples 'field type validation', :remote_user, :not_nil, :non_empty_string diff --git a/devops-service/spec/models/stack/stack_ec2_spec.rb b/devops-service/spec/models/stack/stack_ec2_spec.rb index 17fa499..1e02927 100644 --- a/devops-service/spec/models/stack/stack_ec2_spec.rb +++ b/devops-service/spec/models/stack/stack_ec2_spec.rb @@ -11,7 +11,7 @@ RSpec.describe Devops::Model::StackEc2, type: :model do expect(build(:stack_ec2)).to be_valid end - describe 'validation rules:' do + describe 'validation rules:', stubbed_logger: true do include_examples 'field type validation', :id, :not_nil, :non_empty_string, :field_validator include_examples 'field type validation', :project, :not_nil, :non_empty_string, :field_validator include_examples 'field type validation', :deploy_env, :not_nil, :non_empty_string, :field_validator