permit all symbols in image name

devops-service/db/mongo/models/image.rb

@@ -23,13 +23,13 @@ module Devops
       set_field_validators :id, [::Validators::FieldValidator::NotNil,
                                 ::Validators::FieldValidator::FieldType::String,
                                 ::Validators::FieldValidator::NotEmpty,
-                                ::Validators::FieldValidator::ImageName,
+                                ::Validators::FieldValidator::ImageId,
                                 ::Validators::Image::ImageInFilter]
 
       set_field_validators :remote_user, [::Validators::FieldValidator::NotNil,
                                          ::Validators::FieldValidator::FieldType::String,
                                          ::Validators::FieldValidator::NotEmpty,
-                                         ::Validators::FieldValidator::ImageName]
+                                         ::Validators::FieldValidator::ImageUsername]
 
       set_field_validators :name, [::Validators::FieldValidator::NotNil,
                                   ::Validators::FieldValidator::FieldType::String,

devops-service/db/validators/field_validators/image_id.rb

@@ -0,0 +1,18 @@
+require_relative "base"
+module Validators
+  module FieldValidator
+    class ImageId < Base
+
+      MAX_LEN = 100
+      NAME_REGEX = /\A[\w\-\.]{1,#{MAX_LEN}}\z/
+
+      def valid?
+        !NAME_REGEX.match(@value).nil?
+      end
+
+      def message
+        "Invalid value '#{@value}': it should contains symbols 'a-zA-Z0-9_-.' and length should be more then 1 and less or equals then #{MAX_LEN}"
+      end
+    end
+  end
+end

devops-service/db/validators/field_validators/image_name.rb

@@ -3,15 +3,14 @@ module Validators
   module FieldValidator
     class ImageName < Base
 
-      MAX_NAME_LEN = 100
+      MAX_LEN = 100
-      NAME_REGEX = /\A[\w\-\.]{1,#{MAX_NAME_LEN}}\z/
 
       def valid?
-        !NAME_REGEX.match(@value).nil?
+        @value.length <= MAX_LEN
       end
 
       def message
-        "Invalid value '#{@value}': it should contains symbols 'a-zA-Z0-9_-.' and length should be more then 1 and less or equals then #{MAX_NAME_LEN}"
+        "Invalid value '#{@value}': it should contains symbols 'a-zA-Z0-9_-.' and length should be more then 1 and less or equals then #{MAX_LEN}"
       end
     end
   end

devops-service/db/validators/field_validators/image_username.rb

@@ -0,0 +1,18 @@
+require_relative "base"
+module Validators
+  module FieldValidator
+    class ImageUsername < Base
+
+      MAX_NAME_LEN = 100
+      NAME_REGEX = /\A[\w\-\.]{1,#{MAX_NAME_LEN}}\z/
+
+      def valid?
+        !NAME_REGEX.match(@value).nil?
+      end
+
+      def message
+        "Invalid value '#{@value}': it should contains symbols 'a-zA-Z0-9_-.' and length should be more then 1 and less or equals then #{MAX_NAME_LEN}"
+      end
+    end
+  end
+end

devops-service/spec/models/image_spec.rb

@@ -2,12 +2,13 @@ require 'db/mongo/models/image'
 
 RSpec.describe Devops::Model::Image, type: :model do
   let(:image) { build(:image) }
-  let(:name_with_dash) { 'asd-asd' }
+  let(:string_with_dash) { 'asd-asd' }
-  let(:name_with_slash) { 'asd/asd' }
+  let(:string_with_slash) { 'asd/asd' }
+  let(:string_with_parenthesis) { 'centos 6.5 x86_64 (development instance)' }
 
   before do
     allow(Provider::ProviderFactory).to receive(:providers).and_return(%w(openstack ec2 static'))
-    allow_any_instance_of(Validators::Image::ImageInFilter).to receive(:available_images).and_return([{'id' => 'test_image'}, {'id' => name_with_dash}, {'id' => name_with_slash}])
+    allow_any_instance_of(Validators::Image::ImageInFilter).to receive(:available_images).and_return([{'id' => 'test_image'}, {'id' => string_with_dash}, {'id' => string_with_slash}])
   end
 
   it 'is valid with correct attrs' do
@@ -21,16 +22,24 @@ RSpec.describe Devops::Model::Image, type: :model do
     include_examples 'field type validation', :bootstrap_template, :maybe_nil, :non_empty_string, :only_word_symbols, :field_validator
 
     it 'id should contain only letters, digits and dashes' do
-      expect(build(:image, id: name_with_dash)).to be_valid
+      expect(build(:image, id: string_with_dash)).to be_valid
-      expect(build(:image, id: name_with_slash)).not_to be_valid
+      expect(build(:image, id: string_with_slash)).not_to be_valid
+      expect(build(:image, id: string_with_parenthesis)).not_to be_valid
     end
 
     it "id should be included in image filters" do
       expect(build(:image, id: 'wrong')).not_to be_valid
     end
 
-    it 'name should contain only letters, digits and dashes' do
+    it 'name may contain everything' do
-      expect(build(:image, name: name_with_slash)).not_to be_valid
+      expect(build(:image, name: string_with_dash)).to be_valid
+      expect(build(:image, name: string_with_slash)).to be_valid
+      expect(build(:image, name: string_with_parenthesis)).to be_valid
+    end
+
+    it 'name length should be less or equal than 100' do
+      expect(build(:image, name: 'a'*100)).to be_valid
+      expect(build(:image, name: 'a'*101)).not_to be_valid
     end
 
     it 'bootstrap_template should be included in available bootstrap templates' do