new server initializer

devops-service/db/mongo/models/server.rb

@@ -22,8 +22,20 @@ class Server < MongoModel
     ["chef_node_name", "project", "deploy_env", "provider", "remote_user", "private_ip", "public_ip", "created_at", "created_by", "static", "key", "reserved_by"]
   end
 
-  def initialize
-    self.static = false
+  def initialize s={}
+    self.provider = s["provider"]
+    self.chef_node_name = s["chef_node_name"]
+    self.id = s["_id"]
+    self.remote_user = s["remote_user"]
+    self.project = s["project"]
+    self.deploy_env = s["deploy_env"]
+    self.public_ip = s["public_ip"]
+    self.private_ip = s["private_ip"]
+    self.created_at = s["created_at"]
+    self.created_by = s["created_by"]
+    self.static = s["static"]
+    self.key = s["key"]
+    self.reserved_by = s["reserved_by"]
   end
 
   def validate!
@@ -56,21 +68,7 @@ class Server < MongoModel
   end
 
   def self.create_from_bson s
-    server = Server.new
-    server.provider = s["provider"]
-    server.chef_node_name = s["chef_node_name"]
-    server.id = s["_id"]
-    server.remote_user = s["remote_user"]
-    server.project = s["project"]
-    server.deploy_env = s["deploy_env"]
-    server.public_ip = s["public_ip"]
-    server.private_ip = s["private_ip"]
-    server.created_at = s["created_at"]
-    server.created_by = s["created_by"]
-    server.static = s["static"]
-    server.key = s["key"]
-    server.reserved_by = s["reserved_by"]
-    server
+    Server.new(s)
   end
 
   def info