From 25ef0bd3b5859ca33ae0b0ccfca5114ad388c788 Mon Sep 17 00:00:00 2001 From: Anton Chuchkalov Date: Wed, 13 Jan 2016 13:06:11 +0300 Subject: [PATCH 1/3] fix minor bug in client --- devops-client/lib/devops-client/handler/image.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/devops-client/lib/devops-client/handler/image.rb b/devops-client/lib/devops-client/handler/image.rb index 3ee06d0..9fdc0d0 100644 --- a/devops-client/lib/devops-client/handler/image.rb +++ b/devops-client/lib/devops-client/handler/image.rb @@ -15,7 +15,6 @@ class Image < Handler end def handle - current_command = ARGV[1].to_sym @options, @args = @options_parser.parse_options_for!(current_command) case current_command when :list From a1d987d7e18e84421e18fabf1b925bff83affb85 Mon Sep 17 00:00:00 2001 From: Anton Chuchkalov Date: Thu, 14 Jan 2016 14:17:19 +0300 Subject: [PATCH 2/3] fix project creating bug --- devops-service/providers/ec2.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devops-service/providers/ec2.rb b/devops-service/providers/ec2.rb index dbb5d6b..609186b 100644 --- a/devops-service/providers/ec2.rb +++ b/devops-service/providers/ec2.rb @@ -56,7 +56,7 @@ module Provider end def groups filters={} - g = self.compute.describe_security_groups(filters) + g = self.compute.describe_security_groups(filters || {}) convert_groups(g.body["securityGroupInfo"]) end From 1aed2cf1c9efe26db134e7b493ff5a2fa9072961 Mon Sep 17 00:00:00 2001 From: Anton Chuchkalov Date: Thu, 14 Jan 2016 14:59:44 +0300 Subject: [PATCH 3/3] fix constant name --- devops-service/db/validators/base.rb | 1 + .../db/validators/field_validators/provider_account.rb | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/devops-service/db/validators/base.rb b/devops-service/db/validators/base.rb index 6e3b488..0cb68f9 100644 --- a/devops-service/db/validators/base.rb +++ b/devops-service/db/validators/base.rb @@ -9,6 +9,7 @@ module Validators def validate! raise InvalidRecord.new(message) unless valid? rescue StandardError => e + puts [e.message, e.backtrace].join("\n") raise InvalidRecord.new("An error raised during validation with #{self.class}: #{e.class}: #{e.message}") end diff --git a/devops-service/db/validators/field_validators/provider_account.rb b/devops-service/db/validators/field_validators/provider_account.rb index 3d56074..bd72486 100644 --- a/devops-service/db/validators/field_validators/provider_account.rb +++ b/devops-service/db/validators/field_validators/provider_account.rb @@ -1,11 +1,12 @@ require_relative "base" + module Validators module FieldValidator class ProviderAccount < Base def valid? - accounts = AccountsFactory.accounts(@model.provider) + accounts = ::Provider::AccountsFactory.accounts(@model.provider) accounts.map{|a| a.account_name}.include?(@value) end